What makes a great ring shot? Considering a photograph like this is essentially art, and art is subjective, the overall shot really depends on personal taste. Getting the rings in focus and close without the background distracting is the tricky part.
I use a 100mm f/2.8 macro lens for my ring shots. It took me a while to learn that shooting wide open (f/2.8) to melt away the background wasn’t the best option for these tight ring shots. No no! It’s very hard to focus at that aperture when you’re holding the camera and not convenient to set up a tripod for a steady camera in all situations. What I’ve found to work better for me is shooting at f/4.0. I can get the rings in as much focus as I want while holding the camera in my hands, and the background still falls softly out of focus.
P.S. I am not afraid to admit that I am listening to Christmas music right now!